I recently had an issue with a website timing out a ton of stored procedures because of deadlocks.
Looking back in the error log, I could see it all began when it failed inside the given SP with an arithmetic overflow.
This would normally be no big deal – however this time, it occurred inside an explicit transaction…
The problem is, default behavior on MS SQL server, is to leave the transaction open, and just rollback the statements. This means your client application (in this case a web application) is in charge of closing the transaction.
If this doesn’t happen (and it didn’t), and you’re using pooled connections (which we are), your next query will be run inside the transaction as well – this is *NOT* what you want!
The simple solution is to always SET XACT_ABORT ON in SPs using explicit transations. This will ensure the transaction is closed at server level upon any kind of failure.
Your SP should look like this:
CREATE PROC dbo.Foo AS SET XACT_ABORT ON BEGIN TRANSACTION -- your query COMMIT TRANSACTION
If you want to read more, you may want to check out this article on the topic: Use Caution with Explicit Transactions in Stored Procedures